Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-*: Fix Sheet scroll #1273

Merged
merged 3 commits into from
Jul 2, 2024
Merged

plasma-*: Fix Sheet scroll #1273

merged 3 commits into from
Jul 2, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Jun 28, 2024 •
edited by Salute-Eva
Loading

Sheet

  • убран из примеров в stories лишний горизонтальный скролл
  • добавлена недостающая документация в caldera-online

Before:

scrollBefore

After:

scrollAfter

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1273/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1273/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1273/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1273/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1273/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1273/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1273/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1273/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1273/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav changed the title fix sheet horizontal scroll fix: Sheet horizontal scroll Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@denivladislav denivladislav force-pushed the PLASMA-3066/fix-sheet-horizontal-scroll branch from 555cbc6 to 0c1b5f2 Compare June 28, 2024 15:32
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav changed the title fix: Sheet horizontal scroll fix: Sheet fixes Jun 28, 2024
@denivladislav denivladislav self-assigned this Jun 28, 2024
@denivladislav denivladislav added bugs Something isn't working plasma-components labels Jun 28, 2024
@denivladislav denivladislav marked this pull request as ready for review June 28, 2024 17:23
@denivladislav denivladislav changed the title fix: Sheet fixes fix: Sheet scroll fixes Jun 28, 2024
@Yakutoc Yakutoc requested a review from TitanKuzmich July 1, 2024 05:57
@Yakutoc Yakutoc changed the title fix: Sheet scroll fixes plasma-*: Fix Sheet scroll Jul 1, 2024
@Yakutoc Yakutoc force-pushed the PLASMA-3066/fix-sheet-horizontal-scroll branch from 0c1b5f2 to b37d5bc Compare July 1, 2024 11:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc added this pull request to the merge queue Jul 2, 2024
Merged via the queue into dev with commit 863aef5 Jul 2, 2024
29 checks passed
@Yakutoc Yakutoc deleted the PLASMA-3066/fix-sheet-horizontal-scroll branch July 2, 2024 05:37
@Salute-Eva Salute-Eva mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@denivladislav denivladislav

Labels
bugs Something isn't working plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denivladislav @Yakutoc @TitanKuzmich